Improve Compile-time sequences docs#2204
Conversation
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Add headings. Mention .tupleof.
|
@ntrel your fork seems to be out of date. |
Also fix tupleof: it's a symbol sequence, not a value sequence.
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
A few nits. I definitely like the direction! Thanks a lot!
articles/ctarguments.dd
Outdated
| Ddoc | ||
|
|
||
| $(D_S Compile-time Argument Lists, | ||
| $(D_S $(TITLE)), |
articles/ctarguments.dd
Outdated
| commonly exist in other languages. Sequences of values of different types that can be | ||
| returned from functions are provided by $(LINK2 phobos/std_typecons.html#.Tuple, std.typecons.Tuple). | ||
| Using term "tuple" to mean compile-time lists is discouraged to avoid confusion, and if encountered | ||
| returned from functions are provided by $(PHOBOS typecons, .Tuple, std.typecons.Tuple). |
There was a problem hiding this comment.
$(REF Tuple, std, typecons)
articles/ctarguments.dd
Outdated
| ) | ||
|
|
||
| $(H2 $(LNAME2 homogenous-lists, Homogenous lists)) | ||
| $(H2 $(LNAME2 homogenous-sequences, Homogenous sequences)) |
There was a problem hiding this comment.
LEGACY_LNAME2 to avoid breakage?
articles/ctarguments.dd
Outdated
| --- | ||
|
|
||
| $(P It is possible to use expression lists with values of the same type to declare array literals:) | ||
| $(P $(B Note:) $(PHOBOS typecons, .Tuple, std.typecons.Tuple) wraps a type sequence instance, |
There was a problem hiding this comment.
$(REF Tuple, std, typecons)
| different values) refer to $(LINK2 phobos/std_typecons.html#tuple, Phobos documentation on std.typecons.tuple) | ||
|
|
||
| You may be also looking for documentation for built-in $(LINK2 ctarguments.html, compile-time argument lists) | ||
| You may be also looking for documentation for built-in $(LINK2 ctarguments.html, compile-time sequences) |
There was a problem hiding this comment.
While you are at it, you could update the link to articles/ctarguments.html (not required, there are redirects)
There was a problem hiding this comment.
Haven't done this, but fixed the other points. Thanks for reviewing.
| _= | ||
|
|
||
| $(COMMENT Should be used only when link text is not std.$1.$2 - use REF instead) | ||
| PHOBOS=$(SPANC phobos, $(AHTTPS dlang.org/phobos/std_$1.html#$2, $(TAIL $+))) |
There was a problem hiding this comment.
Let's simply get rid of this deprecated macro: #2195
|
(used the |
|
@wilzbach Tests pass now ;-) Also I removed the comment for the |
3 participants
expression listtovalue sequence(this matches https://dlang.org/spec/template.html#variadic-templates point 2).listtosequence.tupleof.